Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add file extension to custom path part #344
First, thanks for your effort in creating this project! I had halfway started something similar on my own some time ago and abandoned it due to time constraints. What you have done here is way more advanced than what I had accomplished before giving up.
The pull request addresses #271 at least the extension part. I wasn't interested in going further than that but I also felt sad that this IMHO very useful enhancement didn't result in a pull request at the end of it so here it is.
I can also verify that it works as indicated.
EDIT: Btw, I'm more than happy adding a test for this but I wasn't sure if/where/how you are testing for such things. If you point me in the right direction then I can add that to the pull request.
Sorry for the late reply. I'm more than happy to add some unit test for it. Can you point me to the file that does the test for the other parameters in that function? I think it would make sense to have them all in one place, but I don't know the code base well enough.