Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling for null GNSS coords #348

Closed
wants to merge 6 commits into from
Closed

Conversation

@evanjt
Copy link
Contributor

evanjt commented Jan 4, 2020

In the case that the EXIF data is 'dirty' -- well in my case it is. There are images with GNSS data written as available variables, however the coordinates in the file are null, so Python spits a ValueError when this happens and Elodie terminates.

I've added a workaround in this case, where if this happens, the value is set to 0.0 and the program continues. It also prints a line (which maybe is inconsistent with the output of the program and is unecessary), the file then ends up in 'Unknown Location'.

@claassistantio

This comment has been minimized.

Copy link

claassistantio commented Jan 4, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

evanjt
amaleki


amaleki seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

amaleki and others added 5 commits Jan 10, 2020
…ool subprocess to elimate spawing exiftool for each image.
Reduce exiftool calls with metadata object cache.  Enable single exif…
@evanjt evanjt closed this Jan 11, 2020
@evanjt

This comment has been minimized.

Copy link
Contributor Author

evanjt commented Jan 11, 2020

I made some other changes in my dev branch and cleaned up some things. Will submit a pull request when I have a better submission. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.