Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata cache exiftool singleton #352

Merged
merged 9 commits into from Jan 14, 2020
Merged

Metadata cache exiftool singleton #352

merged 9 commits into from Jan 14, 2020

Conversation

@amaleki
Copy link
Contributor

amaleki commented Jan 13, 2020

Fixed all the test errors. Update unit tests to setup/teardown ExifTool singleton.

amaleki added 3 commits Jan 10, 2020
…ool subprocess to elimate spawing exiftool for each image.
@claassistantio

This comment has been minimized.

Copy link

claassistantio commented Jan 13, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Owner

jmathai left a comment

Looking promising. Left comments for the following.

  • Python3 has a single failure where Exiftool isn't available.
  • Python2 has a syntax error with the Singleton metaclass.
elodie/external/pyexiftool.py Outdated Show resolved Hide resolved
amaleki added 3 commits Jan 13, 2020
… runs before tests.
@amaleki amaleki mentioned this pull request Jan 13, 2020
@jmathai

This comment has been minimized.

Copy link
Owner

jmathai commented Jan 13, 2020

@amaleki could you sign the CLA for this?

@amaleki

This comment has been minimized.

Copy link
Contributor Author

amaleki commented Jan 13, 2020

CLA fixed.

@jmathai

This comment has been minimized.

Copy link
Owner

jmathai commented Jan 14, 2020

Thanks! Looks great. I made a couple very minor changes and submitted a PR against your branch. Can merge this PR once you merge mine.

…ngleton

Move setup/teardown to helper module and simplify code in media.py
@amaleki

This comment has been minimized.

Copy link
Contributor Author

amaleki commented Jan 14, 2020

Thank you for the feedback. Changes looked good. Approved and Merged.

@jmathai jmathai merged commit d8cee15 into jmathai:master Jan 14, 2020
4 checks passed
4 checks passed
Scrutinizer 6 new issues, 8 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on metadata-cache-exiftool-singleton at 91.052%
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.