Permalink
Browse files

Fix for retaining large slab buffers in node core

  • Loading branch information...
1 parent 26d3646 commit d2888c83f5eab3fb82425ef4fd51e62621bf2764 @jmatthewsr-ms committed Jan 24, 2013
Showing with 5 additions and 2 deletions.
  1. +5 −2 lib/node-http-proxy/http-proxy.js
@@ -390,12 +390,15 @@ HttpProxy.prototype.proxyRequest = function (req, res, buffer) {
// Performs a WebSocket proxy operation to the location specified by
// `this.target`.
//
-HttpProxy.prototype.proxyWebSocketRequest = function (req, socket, head, buffer) {
+HttpProxy.prototype.proxyWebSocketRequest = function (req, socket, upgradeHead, buffer) {
var self = this,
outgoing = new(this.target.base),
listeners = {},
errState = false,
- CRLF = '\r\n';
+ CRLF = '\r\n',
+ //copy upgradeHead to avoid retention of large slab buffers used in node core
+ head = new Buffer(upgradeHead.length);
+ upgradeHead.copy(head);
//
// WebSocket requests must have the `GET` method and

0 comments on commit d2888c8

Please sign in to comment.