Skip to content

Jorge Bejar
jmbejar

Organizations

@wyeworks
jmbejar opened pull request turbolinks/turbolinks#8
@jmbejar
Add option to skip cache version in links
1 commit with 42 additions and 14 deletions
@jmbejar
  • @jmbejar 4099801
    javascript_include_tag override is also needed for Rails 5
jmbejar commented on pull request modeset/teaspoon#452
@jmbejar

Will do

jmbejar opened pull request modeset/teaspoon#452
@jmbejar
javascript_include_tag override is also needed for Rails 5
1 commit with 1 addition and 1 deletion
@jmbejar
  • @jmbejar 187630f
    javascript_include_tag override is also needed for Rails 5
@jmbejar
  • @jmbejar e4cd9f3
    javascript_include_tag monkey patch also for Rails 5
@jmbejar
@jmbejar
jmbejar opened pull request jnicklas/capybara#1643
@jmbejar
Require addressable gem in CurrentPathQuery
1 commit with 2 additions and 0 deletions
@jmbejar
jmbejar commented on pull request wyeworks/blog#31
@jmbejar

So, the change would be "From the upgrade guide (still very inadequate), we learn that some of the changes in Rails 5.0 are" => "From the upgrade g…

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

I don't like the from the form part. Maybe? The feature test tries to create an Entry using the corresponding form.

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

still very inadequate sounds very strong to me

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

influence is correct in this sentence?

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

I'm noticing that paragraph is probably odd in the Spanish version, specially where the second sentence begins. We could say: The issue is that th…

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

and there the following presents itself <- doesn't it sound a bit odd? What about something like the following? ... it’s a good idea to test the ap…

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

Maybe replace kind isn't saving with the value for kind isn't saving?

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

s/With that fix in the master/With that fix in master

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

s/upload it to the master/push to master

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

I would write this part in passive form, so we don't say "we are reusing all the code.." (since it's Rails' code). but rather it appears because al…

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

I would remove a bit

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

s/The hidden is/The hidden field is

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

I think the following sounds better: "We require capybara/rails in place of minitest/rails/capybara in the test_helper.rb"

jmbejar commented on pull request wyeworks/blog#31
@jmbejar

Looks we have to change We just erased the Gemfile, maybe replacing it with something like We just removed [it|this gem|the entry] from the Gemfile.

jmbejar commented on pull request rails/rails#23062
@jmbejar

:+1: to add more comments and maybe write the rules (#20666 (comment)) somewhere explicitly in the code. Regarding variants, I think the responsibilit…

Something went wrong with that request. Please try again.