New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Terraform to 0.8.8 #36

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@arkan
Contributor

arkan commented Feb 24, 2017

Hey,

Thanks for your Drone plugin. We started using it, however Terraform appeared to be outdated.

This PR is just a quick upgrade to the latest available Terraform version: 0.8.7

Cheers

@jmccann

This comment has been minimized.

Owner

jmccann commented Feb 24, 2017

hehehe. The question is to use package from alpine or manually control versioning in Dockerfile.

Recent work was done by @tboerger via #23 to move away from how it used to be managed (which is what you are basically asking to revert back to).

While we discuss the path to go with in the future ... you do have the option of building/hosting your own docker image of the plugin to get the version of terraform you want.

@arkan

This comment has been minimized.

Contributor

arkan commented Feb 24, 2017

Thanks for the answer @jmccann - We are using our own fork for the moment.

@tboerger

This comment has been minimized.

Contributor

tboerger commented Feb 24, 2017

Beside that, terraform gets compiled statically compiled working on musl? Since when?

@tboerger

This comment has been minimized.

Contributor

tboerger commented Mar 16, 2017

I will update the alpine terraform package now.

@arkan

This comment has been minimized.

Contributor

arkan commented Mar 16, 2017

@tboerger Ideally that would be great if you could derive your image from golang:1.8-alpine in order to have an autonomous build process.
This way, we could easily build new release with a simple push to Github.com and have the build process automatically handled by Docker Hub or Quay.io.

@tboerger

This comment has been minimized.

Contributor

tboerger commented Mar 16, 2017

Ideally the terraform package on the alpine repo gets updated... If building it doesn't fail...

@arkan

This comment has been minimized.

Contributor

arkan commented Mar 16, 2017

I'm not sure we want to depend on Alpine to get the terraform package.
We have very precise needs on the Terraform version and we must be able to control the used version.
If you choose to go this way, we will have to maintain our own fork I think.

@tboerger

This comment has been minimized.

Contributor

tboerger commented Mar 20, 2017

In the end it's the decision of @jmccann. Currently v0.9.0 and v0.8.x fails to build on alpine.

Merge pull request #2 from heetch/feature/alpine-dockerfile
Dockerfile now derives from golang:1.8.0-alpine

@arkan arkan changed the title from Upgrade Terraform to 0.8.7 to Upgrade Terraform to 0.8.8 Mar 20, 2017

@arkan

This comment has been minimized.

Contributor

arkan commented Mar 20, 2017

Yep sure. I updated our fork to be built from a Golang-alpine image :)

@tboerger

This comment has been minimized.

Contributor

tboerger commented Mar 28, 2017

Why are you changing the build process now?

@jmccann

This comment has been minimized.

Owner

jmccann commented Apr 8, 2017

I merged #38 which should address this. Thanks!

@jmccann jmccann closed this Apr 8, 2017

@jmccann

This comment has been minimized.

Owner

jmccann commented Apr 8, 2017

FYI, created new docker tag jmccann/drone-terraform:1-0.8.8 for this ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment