New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import zipfile to avoid problem with late import #428

Merged
merged 1 commit into from Sep 9, 2018

Conversation

Projects
None yet
2 participants
@mrbean-bremen
Collaborator

mrbean-bremen commented Sep 9, 2018

@mrbean-bremen

This comment has been minimized.

Show comment
Hide comment
@mrbean-bremen

mrbean-bremen Sep 9, 2018

Collaborator

@jmcgeheeiv - the problem is the late import of zipfile in shutil, so that the patcher doesn't know about it. I don't have any other idea how to fix this apart from importing zipfile in our code - maybe you have an idea...

Collaborator

mrbean-bremen commented Sep 9, 2018

@jmcgeheeiv - the problem is the late import of zipfile in shutil, so that the patcher doesn't know about it. I don't have any other idea how to fix this apart from importing zipfile in our code - maybe you have an idea...

@mrbean-bremen mrbean-bremen requested a review from jmcgeheeiv Sep 9, 2018

@jmcgeheeiv jmcgeheeiv merged commit eeb80f6 into jmcgeheeiv:master Sep 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrbean-bremen mrbean-bremen deleted the mrbean-bremen:issue427 branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment