New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling issue with non 96dpi images #164

Closed
jmcnamara opened this Issue Oct 10, 2014 · 3 comments

Comments

2 participants
@jmcnamara
Owner

jmcnamara commented Oct 10, 2014

Images with resolutions other than 96dpi aren't scaled properly in the output xlsx file.

This may not be noticeable with 72dpi images but is more obvious with larger resolutions like 300dpi.

The current workaround is to use 96dpi images.

There will be a fix for this in the next release.

@jmcnamara jmcnamara added the bug label Oct 10, 2014

@jmcnamara jmcnamara self-assigned this Oct 10, 2014

jmcnamara added a commit that referenced this issue Oct 12, 2014

Fixed handling of images with DPIs other than 96.
Fixed handling of non-96dpi images by parsing out the DPI from
the image and applying the appropritate scaling.

Issue #164.
@jmcnamara

This comment has been minimized.

Show comment
Hide comment
@jmcnamara

jmcnamara Oct 12, 2014

Owner

@abirmingham

This fix to XlsxWriter also fixes the issue that you were having in #32 with a logo with 95.99 dpi.

Owner

jmcnamara commented Oct 12, 2014

@abirmingham

This fix to XlsxWriter also fixes the issue that you were having in #32 with a logo with 95.99 dpi.

@jmcnamara

This comment has been minimized.

Show comment
Hide comment
@jmcnamara

jmcnamara Oct 14, 2014

Owner

Fixed in version 0.6.0 on PyPI.

Owner

jmcnamara commented Oct 14, 2014

Fixed in version 0.6.0 on PyPI.

@jmcnamara jmcnamara closed this Oct 14, 2014

@abirmingham

This comment has been minimized.

Show comment
Hide comment
@abirmingham

abirmingham Oct 14, 2014

Great memory, John. Many thanks!

Great memory, John. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment