New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shebang on vba_extract.py set incorrectly in wheel #211

Closed
cassidylaidlaw opened this Issue Jan 15, 2015 · 4 comments

Comments

2 participants
@cassidylaidlaw

The shebang at the beginning of vba_extract.py is set to #!/Users/John/.pythonbrew/pythons/Python-2.7.2/bin/python which is specific to a particular installation. It should probably be changed to just #!python.

Example which demonstrates the problem:

$ vba_extract.py
bash: /usr/local/bin/vba_extract.py: /Users/John/.pythonbrew/pythons/Python-2.7.2/bin/python: bad interpreter: No such file or directory
@jmcnamara

This comment has been minimized.

Show comment
Hide comment
@jmcnamara

jmcnamara Jan 15, 2015

Owner

Hi,

Thanks for the report.

The shebang line is actually set to #!/usr/bin/python in the repo as you can see here: vba_extract.py.

This is also the case for the distro in PyPi: https://pypi.python.org/pypi/XlsxWriter#downloads

However, it looks like the packager for the wheel (.whl) distro is converting the shebang line to the one you see.

That seems like a really bad idea on the part of the wheel packager.

I'll see if I can avoid that somehow in the config or if not I'll remove the wheel and just let the installer use the tar.gz distro.

Regards,

John

Owner

jmcnamara commented Jan 15, 2015

Hi,

Thanks for the report.

The shebang line is actually set to #!/usr/bin/python in the repo as you can see here: vba_extract.py.

This is also the case for the distro in PyPi: https://pypi.python.org/pypi/XlsxWriter#downloads

However, it looks like the packager for the wheel (.whl) distro is converting the shebang line to the one you see.

That seems like a really bad idea on the part of the wheel packager.

I'll see if I can avoid that somehow in the config or if not I'll remove the wheel and just let the installer use the tar.gz distro.

Regards,

John

@jmcnamara jmcnamara self-assigned this Jan 15, 2015

@jmcnamara jmcnamara added the bug label Jan 15, 2015

@jmcnamara jmcnamara changed the title from Shebang on vba_extract.py set incorrectly to Shebang on vba_extract.py set incorrectly in wheel Jan 15, 2015

@jmcnamara

This comment has been minimized.

Show comment
Hide comment
@jmcnamara

jmcnamara Jan 16, 2015

Owner

Hi,

I've pushed a new version to PyPI with a '#!python' shebang line.

I've tried it on a few different systems and it seems to work. Can you test it to see if it works on your system.

Regards,

John

Owner

jmcnamara commented Jan 16, 2015

Hi,

I've pushed a new version to PyPI with a '#!python' shebang line.

I've tried it on a few different systems and it seems to work. Can you test it to see if it works on your system.

Regards,

John

@cassidylaidlaw

This comment has been minimized.

Show comment
Hide comment
@cassidylaidlaw

cassidylaidlaw Jan 20, 2015

Works for me! Thank you for the quick fix.

Cassidy

Works for me! Thank you for the quick fix.

Cassidy

@jmcnamara

This comment has been minimized.

Show comment
Hide comment
@jmcnamara

jmcnamara Feb 4, 2015

Owner

Thanks for the confirmation that the fix worked. Closing.

Owner

jmcnamara commented Feb 4, 2015

Thanks for the confirmation that the fix worked. Closing.

@jmcnamara jmcnamara closed this Feb 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment