New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lavc as valid marker3 for jpeg images #40

Closed
sbreuss opened this Issue Aug 26, 2013 · 5 comments

Comments

2 participants
@sbreuss

sbreuss commented Aug 26, 2013

After capturing several images from videos as jpeg with ffmpeg the workbook raises the exception 'Unknown or unsupported file type.'

This happenes due to the fact that marker3 is neither 'JFIF' nor 'EXIF', but Lavc'.
After adding 'Lavc' as a valid option for JPEG markers in Workbook._get_image_properties everything works as expected.

Best regards,
Simon Breuss

@ghost ghost assigned jmcnamara Aug 26, 2013

@jmcnamara

This comment has been minimized.

Show comment
Hide comment
@jmcnamara

jmcnamara Aug 26, 2013

Owner

Hi Simon,

No problem, I'll add that.

Could you send me, or attach here, a few sample images that I could use as test cases.

Regards,

John

Owner

jmcnamara commented Aug 26, 2013

Hi Simon,

No problem, I'll add that.

Could you send me, or attach here, a few sample images that I could use as test cases.

Regards,

John

@sbreuss

This comment has been minimized.

Show comment
Hide comment
@sbreuss

sbreuss Aug 26, 2013

No problem and thx for the fast reply.

Regards,
Simon

20130825_114959_still
20130825_110428_still

sbreuss commented Aug 26, 2013

No problem and thx for the fast reply.

Regards,
Simon

20130825_114959_still
20130825_110428_still

@jmcnamara

This comment has been minimized.

Show comment
Hide comment
@jmcnamara

jmcnamara Aug 26, 2013

Owner

Hi Simon,

Any objection to having one of those images stored in the git repository if it is used in an automated test case?

John

Owner

jmcnamara commented Aug 26, 2013

Hi Simon,

Any objection to having one of those images stored in the git repository if it is used in an automated test case?

John

@sbreuss

This comment has been minimized.

Show comment
Hide comment
@sbreuss

sbreuss Aug 26, 2013

No problem from my side.

Simon

sbreuss commented Aug 26, 2013

No problem from my side.

Simon

jmcnamara added a commit that referenced this issue Aug 26, 2013

@jmcnamara

This comment has been minimized.

Show comment
Hide comment
@jmcnamara

jmcnamara Aug 26, 2013

Owner

Fixed in version 0.4.0 with additional test case based on your image.

Thanks for the report.

John

Owner

jmcnamara commented Aug 26, 2013

Fixed in version 0.4.0 with additional test case based on your image.

Thanks for the report.

John

@jmcnamara jmcnamara closed this Aug 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment