New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Row Inserted Even When Turned Off #405

Closed
dieherna opened this Issue Dec 25, 2016 · 3 comments

Comments

2 participants
@dieherna

dieherna commented Dec 25, 2016

When creating a table with the header_row set to "False", a header row with empty data is inserted into the table. This causes the table to exclude the last row in the input data as the table range has been exceeded.

Issue seen in xlsxwriter-0.9.4 & xlsxwriter-0.9.5.

Sample Code:

import xlsxwriter

workbook = xlsxwriter.Workbook("test.xlsx")
sheet = workbook.add_worksheet()
data = [["apple", "pie"], ["pine", "tree"]]

sheet.add_table("B2:C3", {"data": data, "header_row": False})

workbook.close()

@jmcnamara jmcnamara self-assigned this Dec 25, 2016

@jmcnamara jmcnamara added the question label Dec 25, 2016

@jmcnamara jmcnamara added bug short term and removed question labels Dec 25, 2016

@jmcnamara

This comment has been minimized.

Show comment
Hide comment
@jmcnamara

jmcnamara Dec 25, 2016

Owner

Hi @dieherna,

I've pushed a fix for his to the master branch.

Regards,

John

Owner

jmcnamara commented Dec 25, 2016

Hi @dieherna,

I've pushed a fix for his to the master branch.

Regards,

John

jmcnamara added a commit that referenced this issue Dec 26, 2016

@dieherna

This comment has been minimized.

Show comment
Hide comment
@dieherna

dieherna Dec 26, 2016

Works perfectly! Thanks heaps for resolving! :)

Works perfectly! Thanks heaps for resolving! :)

@dieherna dieherna closed this Dec 26, 2016

@jmcnamara

This comment has been minimized.

Show comment
Hide comment
@jmcnamara

jmcnamara Dec 26, 2016

Owner

Fixed in version 0.9.6.

Owner

jmcnamara commented Dec 26, 2016

Fixed in version 0.9.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment