Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Running with -Werrror raises deprecation warning #451
referenced this issue
Jun 30, 2017
This snippet shows the issue:
I ran into this because I was running with
Thanks for the update.
Ok. I see it now.
The deprecation notice comes from this PR: #401 where the submitter says:
So I'll probably leave the deprecation warning there for a month or two, or until the next release (whichever comes later).
Unfortunately, I can't do that. I wasn't keen on adding a deprecation warning on an internal method, or at all, but it was/is used by people subclassing the module even if it isn't a public interface. So it is only fair to add some sort of warning.
Maybe your can run your tests with reduced warnings around your XlsxWriter, for now.
I'll make a few comments on your PR and I'll use that when I deprecate the warning.
That's not what I meant though, and it's not what the patch does. The deprecation warning on the internal method stays. The patch just fixes the internal usage of that internal method, so that the public API doesn't throw up the warning.
To me, a deprecation warning when using a public API make sense only when there's a non-deprecated way of doing things.