New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for python 3 #15

Merged
merged 1 commit into from Jun 9, 2013

Conversation

2 participants
@shadchin
Contributor

shadchin commented May 16, 2013

for Windows Rus (default encoded cp1251):
open(filename, 'w')
filename will be encoded cp1251 for python >= 3

@jmcnamara

This comment has been minimized.

Show comment
Hide comment
@jmcnamara

jmcnamara May 16, 2013

Owner

Hi,

Thanks for that. Unicode differences between Python 2 and 3 really are a pain. :-(

This issue was probably introduced when I dropped the codecs UTF-8 encoding in the last release (it was 10-20%) slower.

Thanks for the fix.

John

Owner

jmcnamara commented May 16, 2013

Hi,

Thanks for that. Unicode differences between Python 2 and 3 really are a pain. :-(

This issue was probably introduced when I dropped the codecs UTF-8 encoding in the last release (it was 10-20%) slower.

Thanks for the fix.

John

@ghost ghost assigned jmcnamara May 27, 2013

jmcnamara added a commit that referenced this pull request Jun 9, 2013

@jmcnamara jmcnamara merged commit 3304f4f into jmcnamara:master Jun 9, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment