windowHeight and windowWidth #59

Closed
aaronpriven opened this Issue Mar 28, 2013 · 5 comments

Projects

None yet

2 participants

@aaronpriven

It would be nice to have setter and getter methods for the _window_width and _window_height attributes of the Workbook object. If I break encapsulation I can set them, and it works:

my $workbook = Excel::Writer::XLSX->new($out);
$workbook->{_window_height} = 950 * 20;
$workbook->{_window_width}  = 1200 * 20;

but it makes me feel so dirty inside.

P.S. Thanks so much for creating this, it is fantastic.

@jmcnamara jmcnamara was assigned Mar 29, 2013
@jmcnamara
Owner

Hi Aaron,

I was waiting for someone to ask for that feature before I implemented it. I'm surprised it took this long. :-)

I've marked it as TODO and I'll add a proper API around it.

In the meantime, you are safe enough with your workaround. The internals won't change.

John.

@aaronpriven
@jmcnamara jmcnamara added a commit that referenced this issue Jun 12, 2016
@jmcnamara Added workbook set_size() method.
Issue #59.
8db7732
@jmcnamara
Owner

It took me a while to get around to this, and you have probably moved on by now, but I've added a workbook set_size() in version 0.95 of Excel::Writer::XLSX.

Thanks for the prompt.

John

@jmcnamara jmcnamara closed this Jun 12, 2016
@aaronpriven
aaronpriven commented Jun 21, 2016 edited
@aaronpriven
aaronpriven commented Aug 10, 2016 edited

Just wanted to indicate that I'd actually used this:

aaronpriven/actium@9a53fca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment