New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #10 (spelling mistakes and POD encoding) #14

Merged
merged 2 commits into from Mar 5, 2015

Conversation

Projects
None yet
2 participants
@zoffixznet
Contributor

zoffixznet commented Mar 5, 2015

No description provided.

@jmcnamara

This comment has been minimized.

Owner

jmcnamara commented Mar 5, 2015

Fixed spelling mistakes and POD encoding

I prefer separate changes to be in separate commits, and if they aren't related then in separate PRs.

So it would be best to rebase this into 2 commits.

However, I'd also prefer that encoding utf8 isn't applied to files that don't need it. So leave it out if it isn't specifically required.

Thanks,

John

@zoffixznet

This comment has been minimized.

Contributor

zoffixznet commented Mar 5, 2015

How's this?

jmcnamara added a commit that referenced this pull request Mar 5, 2015

Merge pull request #14 from zoffixznet/fix_spelling_issue_10
Fixed #10 (spelling mistakes and POD encoding)

@jmcnamara jmcnamara merged commit 305e5e7 into jmcnamara:master Mar 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmcnamara

This comment has been minimized.

Owner

jmcnamara commented Mar 6, 2015

Perfect. Thanks.

@zoffixznet zoffixznet deleted the zoffixznet:fix_spelling_issue_10 branch Mar 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment