New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for malformed formatting (Issue #12) #16

Merged
merged 1 commit into from Mar 8, 2015

Conversation

Projects
None yet
2 participants
@zoffixznet
Contributor

zoffixznet commented Mar 7, 2015

This is for Issue #12

I added the test to check for the described problem (the current version of the module does that URL conversion just fine, so only the extra tests were needed).

@jmcnamara

This comment has been minimized.

Owner

jmcnamara commented Mar 8, 2015

I added the test to check for the described problem (the current version of the module does that URL conversion just fine, so only the extra tests were needed).

Hi Zoffix,

Apologies, I missed the part in the original post where the issue was already resolved.

Thanks for the patch.

John

jmcnamara added a commit that referenced this pull request Mar 8, 2015

Merge pull request #16 from zoffixznet/fix_malformed_URL_formatting_i…
…ssue_12

Test for malformed formatting

(Issue #12)

@jmcnamara jmcnamara merged commit 6c3b216 into jmcnamara:master Mar 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zoffixznet zoffixznet deleted the zoffixznet:fix_malformed_URL_formatting_issue_12 branch Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment