New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes RT#38833 / Issue #4: escaping special symbols in text and headers #17

Merged
merged 1 commit into from Mar 8, 2015

Conversation

Projects
None yet
2 participants
@zoffixznet
Contributor

zoffixznet commented Mar 8, 2015

This fixes https://rt.cpan.org/Public/Bug/Display.html?id=38833 (references in #4) and adds a test.

Output checked on Confluence trial version server.

@jmcnamara

This comment has been minimized.

Owner

jmcnamara commented Mar 8, 2015

Hi Zoffix,

The patches have been good so far.

As a rule I don't like issue number in the commit subject like. These are better in the body with a more general, and short, explanation as the subject.

How example for this commit I would have written it something like this:

Fixed Confluence symbol escaping in text and headers

Fixed escaping of special symbols in text and headers for the Confluence
wiki format.

RT#38833 / Issue #4.

I'll merge this as it is and push it to CPAN.

Thanks,

John

jmcnamara added a commit that referenced this pull request Mar 8, 2015

Merge pull request #17 from zoffixznet/fix_RT_38833
Fixed escaping of special symbols in text and headers for the Confluence
wiki format.

RT#38833 / Issue #4.

@jmcnamara jmcnamara merged commit ff571fc into jmcnamara:master Mar 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment