Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize Phobos skipOver #10

Closed
JesseKPhillips opened this issue May 4, 2018 · 1 comment
Closed

Utilize Phobos skipOver #10

JesseKPhillips opened this issue May 4, 2018 · 1 comment
Labels
0.4 enhancement New feature or request

Comments

@JesseKPhillips
Copy link

dxml/source/dxml/parser.d

Line 1859 in 8dbc4a4

if(_text.stripStartsWith("<?xml"))

You should be able to utilize: https://dlang.org/library/std/algorithm/searching/skip_over.skip_over.html
rather than the custom function.
@jmdavis jmdavis added the enhancement New feature or request label Jul 10, 2018
@jmdavis
Copy link
Owner

jmdavis commented Jul 10, 2018

It actually can't use it directly, because stripStartsWith doesn't take a range directly, and it handles incrementing the position, which skipOver doesn't do. However, stripStartsWith can be simplified to use skipOver internally.

@jmdavis jmdavis added the 0.4 label Jul 10, 2018
jmdavis added a commit that referenced this issue Jul 10, 2018
@jmdavis
Leverage skipOver in skipStartsWith.
a0467d7 
#10

This reduces the complexity of skipStartsWith. However, at some point,
it should be further improved to strip off the wrappers around arrays of
char so that skipOver can use == when comparing when the type being
parsed is an array of char.
@jmdavis jmdavis closed this as completed Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.4 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JesseKPhillips @jmdavis