Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added https type 65 to DNSRecordType #213

Closed
wants to merge 1 commit into from
Closed

Added https type 65 to DNSRecordType #213

wants to merge 1 commit into from

Conversation

gjvanderheiden
Copy link

When using Safari on MacOs 11, I got an error in jmdns. From this site
https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml
I found is is HTTPS, in a draft version of a rfc
https://datatracker.ietf.org/doc/draft-ietf-dnsop-svcb-https/00/

This pull request prevents Exceptions to be throws for unknown index type, for example:
"WARN javax.jmdns.impl.constants.DNSRecordType - Could not find record type for index: 65"
"WARN javax.jmdns.impl.DNSIncoming - Could not find record type: dns[query,192.168.178.4:5353, length=31, id=0x0]
0: 0000000000010000 00000000076f7065 6e686162056c6f63 616c0000418001 ........ .....ope nhab.loc al..A.."

This prevents Exceptions to be throws for unknown index type, for example:
"WARN javax.jmdns.impl.constants.DNSRecordType - Could not find record type for index: 65"
"WARN javax.jmdns.impl.DNSIncoming - Could not find record type: dns[query,192.168.178.4:5353, length=31, id=0x0]
    0: 0000000000010000 00000000076f7065 6e686162056c6f63 616c0000418001       ........ .....ope nhab.loc al..A.."

Signed-off-by: Gert-Jan van der Heiden <gjvdspam@gmail.com>
@ViToni
Copy link
Contributor

ViToni commented Dec 2, 2020

@gjvanderheiden Are you sure this is enough? The spec defines a special RDATA wire format for which there is no parser.
Or is the RDATA just skipped if there is no parser in place for the specific RR type.

@gjvanderheiden
Copy link
Author

@ViToni This pr merely suppresses the warning message.

This is what I did:

  1. clone master and mvn clean install
  2. Updated to the SNAPSHOT version in hap-java
  3. Used it in my local test.

Without the pr I could easily reproduce it: Just open safari and open a local https site, in this case openhab.local.
After this simple enum addition I didn't get the warning. Running with the small patch for a day on the same host, openhab.local, no messages in the log. I also could run the jmdns on my local machine, not being openhab.local, same warning would arise without the pr.

hope this helps.

@tmm1
Copy link

tmm1 commented Mar 10, 2021

Ping? I'm seeing the same issue.

03-10 10:01:58.774 29905 29966 W DNSRecordType: Could not find record type for index: 65
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming: Could not find record type: dns[query,fe80::414:ee3a:a0b2:829f%wlan0:5353, length=770, id=0x0, questions=2
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming: questions:
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming: 	[Pointer@192774841 type: TYPE_PTR index 12, class: CLASS_IN index 1, name: _companion-link._tcp.local.]
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming: 	[Pointer@106641150 type: TYPE_PTR index 12, class: CLASS_IN index 1, name: _homekit._tcp.local.]]
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming: 	question:      [Pointer@192774841 type: TYPE_PTR index 12, class: CLASS_IN index 1, name: _companion-link._tcp.local.]
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming: 	question:      [Pointer@106641150 type: TYPE_PTR index 12, class: CLASS_IN index 1, name: _homekit._tcp.local.]
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:    0: 0000000000060012 000000010f5f636f 6d70616e696f6e2d 6c696e6b045f7463     ........ ....._co mpanion- link._tc
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:   20: 70056c6f63616c00 000c0001085f686f 6d656b6974c01c00 0c00010377777708     p.local. ....._ho mekit... ....www.
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:   40: 6f6666696365346b c02100410001c03b 001c0001c03b0001 00010c5f736c6565     office4k .!.A...; .....;.. ..._slee
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:   60: 702d70726f787904 5f756470c021000c 0001c00c000c0001 00001188000a0748     p-proxy. _udp.!.. ........ .......H
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:   80: 616c6c776179c00c c00c000c00010000 1188000c09746d6d 312d6d696e69c00c     allway.. ........ .....tmm 1-mini..
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:   a0: c00c000c00010000 1188000a07746d6d 312d6d31c00cc00c 000c000100001188     ........ .....tmm 1-m1.... ........
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:   c0: 000c09746d6d312d 696d6163c00cc00c 000c000100001188 000d0a6f66666963     ...tmm1- imac.... ........ ...offic
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:   e0: 6520283229c00cc0 0c000c0001000011 880009066f666669 6365c00cc00c000c     e.(2)... ........ ....offi ce......
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  100: 000100001188000b 086f666669636534 4bc00cc00c000c00 0100001188000d0a     ........ .office4 K....... ........
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  120: 6f66666963652028 3329c00cc02c000c 0001000011880027 2430353536464246     office.( 3)...,.. .......' $0556FBF
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  140: 332d313333302d35 3038362d42434238 2d36334238313333 4146333833c02cc0     3-1330-5 086-BCB8 -63B8133 AF383.,.
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  160: 2c000c0001000011 8800272442374535 454432392d413544 412d353044322d39     ,....... ..'$B7E5 ED29-A5D A-50D2-9
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  180: 3931412d38414443 3535314431443432 c02cc02c000c0001 0000118800272430     91A-8ADC 551D1D42 .,.,.... .....'$0
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  1a0: 313136454432442d 323843342d354341 442d384436412d36 4536393833423742     116ED2D- 28C4-5CA D-8D6A-6 E6983B7B
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  1c0: 354134c02cc02c00 0c00010000118800 2724383544314530 39462d314242392d     5A4.,.,. ........ '$85D1E0 9F-1BB9-
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  1e0: 353730362d393037 422d463938354630 434537414137c02c c02c000c00010000     5706-907 B-F985F0 CE7AA7., .,......
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  200: 1188002724304235 34454436442d3146 32372d353437342d 384134462d303438     ...'$0B5 4ED6D-1F 27-5474- 8A4F-048
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  220: 4441464138444633 30c02cc05a000c00 0100001188001815 37302d33352d3630     DAFA8DF3 0.,.Z... ........ 70-35-60
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  240: 2d36332e31204861 6c6c776179c05ac0 5a000c0001000011 88001b1837302d33     -63.1.Ha llway.Z. Z....... ....70-3
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  260: 352d36302d36332e 31206f6666696365 20283229c05ac05a 000c000100001188     5-60-63. 1.office .(2).Z.Z ........
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  280: 00171437302d3335 2d36302d36332e31 206f6666696365c0 5ac05a000c000100     ...70-35 -60-63.1 .office. Z.Z.....
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  2a0: 0011880019163730 2d33352d36302d36 332e31206f666669 6365344bc05ac05a     ......70 -35-60-6 3.1.offi ce4K.Z.Z
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  2c0: 000c000100001188 001b1837302d3335 2d36302d36332e31 206f666669636520     ........ ...70-35 -60-63.1 .office.
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  2e0: 283329c05a000029 05a0000011940012 0004000e0017fa10 93d3a4bc0613a54d     (3).Z..) ........ ........ .......M
03-10 10:01:58.791 29905 29966 W j*.j*.i*.DNSIncoming:  300: b6b9                                                                    ..

cc @kaikreuzer

@gjvanderheiden
Copy link
Author

too long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants