Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More integration Tests Required #166

Open
Ardesco opened this Issue Mar 10, 2016 · 2 comments

Comments

2 participants
@Ardesco
Copy link
Contributor

Ardesco commented Mar 10, 2016

We need to add more integration tests (living in the src/it folder) to cover various usage scenarios.

Right now we only have a single test that just checks that the plugin can run a basic test with no additional configuration (This can be used as an example on how to configure other integration tests). We should be testing various configuration options as well.

Requirements:

  • The .jmx files used must be as small as possible (If the format changes we want to be able to recreate them quickly and easily).
  • We want to check that the functionality of the plugin works, we don't want to run actual performance or soak tests.
  • We should really be running the tests against a local hello world app spun up in a container before the integration tests start and then shut down after they have finished, we shouldn't need a network connection for these tests to work.

@Ardesco Ardesco added the help wanted label Mar 10, 2016

@Ardesco Ardesco added the ready label Feb 15, 2017

pmouawad added a commit that referenced this issue Nov 12, 2017

pmouawad added a commit that referenced this issue Nov 12, 2017

More integration Tests Required
Split jacoco into test and it
This comments #166

pmouawad added a commit that referenced this issue Nov 12, 2017

More integration Tests Required
Fix Jacoco config
This comments #166

pmouawad added a commit that referenced this issue Nov 12, 2017

More integration Tests Required
Fix Jacoco config
This comments #166
@pmouawad

This comment has been minimized.

Copy link
Contributor

pmouawad commented Nov 12, 2017

@Ardesco , the easiest way is to use Java Request witg Java Test, it allows:

  • Mocking a response
  • Setting some response code/message
  • Setting some response time

I've used it in test-plugins and remote-test.

@pmouawad pmouawad added in progress and removed ready labels Nov 12, 2017

@Ardesco

This comment has been minimized.

Copy link
Contributor Author

Ardesco commented Nov 13, 2017

We can make it as easy or as complicated as we want to be honest.

Just adding more integration tests to ensure stuff keeps working as we release new versions is what this ticket is all about. Thanks for adding the ones you have added so far.

@pmouawad pmouawad added this to the 2.8.0 milestone Feb 11, 2018

@pmouawad pmouawad added this to Low priority in ISSUE TRACKING Aug 3, 2018

@pmouawad pmouawad modified the milestones: 2.8.0, 2.9.0 Oct 4, 2018

@pmouawad pmouawad modified the milestones: 2.8.1, 2.8.2 Nov 11, 2018

@pmouawad pmouawad modified the milestones: 2.8.2, 2.8.3 Dec 27, 2018

@pmouawad pmouawad modified the milestones: 2.8.3, 2.8.4 Jan 15, 2019

@pmouawad pmouawad modified the milestones: 2.8.4, 2.8.5 Jan 29, 2019

@pmouawad pmouawad modified the milestones: 2.8.6, 2.8.7 Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.