Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study possibility to make goals ThreadSafe #310

Open
pmouawad opened this Issue Feb 16, 2019 · 7 comments

Comments

Projects
None yet
2 participants
@pmouawad

This comment has been minimized.

Copy link
Contributor Author

pmouawad commented Feb 16, 2019

IMU:

(to be continued)

@pmouawad pmouawad changed the title Study possibility to make tasks ThreadSafe Study possibility to make goals ThreadSafe Feb 16, 2019

@Ardesco

This comment has been minimized.

Copy link
Contributor

Ardesco commented Feb 19, 2019

What benefit does running it in multithreaded mode give you? There seems little point in loading JMeter up in 2 separate JVM's to add more load when you can just increase the thread count in the JMeter config and save some system resources.

@pmouawad

This comment has been minimized.

Copy link
Contributor Author

pmouawad commented Feb 19, 2019

I also think it is incorrect to run simultaneous load tests without clearly controlling what is ran. Analysis will be harder if not impossible.

But there is a possibility that JMeter is used for functional testing, in this case this request could be legitimate.

@Ardesco

This comment has been minimized.

Copy link
Contributor

Ardesco commented Feb 19, 2019

there is nothing stopping you running multiple tests in different terminal windows if you want to load different test plans in parallel, I would suggest this is better because you can stop and start individual test plans to see how they affect load. You couldn't do that if everything was running in parallel in a group of test plans (even if they are running in separate threads).

To be honest I've not thought of it from a functional test point of view, that's not something I would have thought to use JMeter for. I would suggest that people that tend to do this sort of thing see JMeter as a hammer and suddenly everything looks like a nail. Surely to a degree it all depends upon how the tests are structured. If you have multiple jUnit tests in a single test plan running in forked mode in maven wouldn't do anything anyway, you would have to have multiple test plans with individual functional tests.

@pmouawad

This comment has been minimized.

Copy link
Contributor Author

pmouawad commented Feb 19, 2019

HI @Ardesco ,
Just to be clear, I am not the requester.
It was requested on google group of plugin, just putting it here.

Regards

@Ardesco

This comment has been minimized.

Copy link
Contributor

Ardesco commented Feb 19, 2019

I read the links and I know you aren't the requestor :)

I'm using "you" in the third person, assume I'm saying "someone" when I write "you" and it will probably be clearer.

@Ardesco

This comment has been minimized.

Copy link
Contributor

Ardesco commented Feb 21, 2019

I'm going to suggest we close this as WontFix.

I can't see any benefits to making the plugin thread safe at this moment in time and we also don't have any tests to ensure it is thread safe. If people want to spin up multiple threads they can risk it, but it's not something we officially support.

I also don't see an easy way to fix the "RepositorySystemSession" issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.