Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Reports is running in the wrong phase #328

Open
Ardesco opened this Issue Apr 9, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@Ardesco
Copy link
Contributor

Ardesco commented Apr 9, 2019

Report generation should run in the verify phase along with check results, it's currently running in the integration test phase.

When we moved from 1.x to 2.x we moved the reporting tasks into a separate phase to allow people to break up the process of performing tests and checking/parsing the test results. At this point reporting was not part of JMeter so the recommended solution was to run another plugin to generate reports.

Potentially long running processes like scanning results files for failures were moved to the verify phase to allow users only interested in running a test and collecting the results for usage elsewhere to perform their actions quickly. People who wanted to use additional long running commands like parsing results files could still do this, but these long running commands were moved into the verify phase this provided 2 benefits:

  • Users did not have to wait for results to be parsed after running tests if they were not interested in our plugin parsing results.
  • The verify phase could be used in isolation, so in theory results parsing/report generation could be run at any point with existing test results.

We should do the following:

  • Remove report generation from the integration test phase and no longer perform this as part of the standard test run
  • Add report generation to CheckResultsMojo to ensure it runs in the verify phase
  • Add the ability to configure the test results folder separately in the verify phase, this will allow users to specify existing test result files (potentially ones not generated by running JMeter as part of the JMeter-maven-plugin) that can be verified in isolation

@Ardesco Ardesco added the bugs label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.