<excludedArtifacts> not working as expected

[tomcruise81]

• Java: 1.8.0_301
• Maven: 3.8.6
• JMeter-Maven-Plugin: 3.6.1

This might be related to #419, but I'm not 100% sure on that.

I've tried to supply <testPlanLibraries> with a number of <artifact> entries.

Unfortunately, it brings in ALL transitive dependencies from those artifacts, including those at test scopes.

So to try and alleviate that, I attempted to exclude the test scoped transitive dependencies via <excludedArtifacts>.

It appears as if <testPlanLibraries> takes precedence over <excludedArtifacts>, because NONE of the <exclusion> entries that I supplied under <excludedArtifacts> were actually excluded.

[tomcruise81]

The only thing that I've gotten to remotely work is to follow the advice of https://stackoverflow.com/a/42345443/6262804 and set

<downloadExtensionDependencies>false</downloadExtensionDependencies>

I was able to get the full dependency list via

mvn com.github.ferstl:depgraph-maven-plugin:4.0.2:for-artifact -Dartifact=$TARGET_GAV_COORDINATES -DgraphFormat=text -DclasspathScope=compile -DshowGroupIds=true -DshowVersions=true

Then I explicitly add all of my dependencies as <artifact> entries.

Obviously, this isn't ideal as with each time we upgrade our actual desired libraries, we'll have to go through multiple steps to keep all the transitive dependencies up to date, whereas Maven can do that kind of stuff for us.

[ratoaq2]

The issue is because https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/blob/main/src/main/java/com/lazerycode/jmeter/mojo/ConfigureJMeterMojo.java#L508 doesn't take the exclusions into consideration

[ratoaq2]

Looking at the source code, you can use ignoredArtifacts... not sure if this is documented:

<ignoredArtifacts>
  <artifact>org.hibernate.orm:hibernate-core:6.1.6.Final</artifact>
</ignoredArtifacts>

[tomcruise81]

It looks like the root of my problems is:

• jmeter-maven-plugin/src/main/java/com/lazerycode/jmeter/mojo/ConfigureJMeterMojo.java

  Line 313 in e948c05

  copyExplicitLibraries(testPlanLibraries, libDirectory.toFile(), downloadLibraryDependencies, "test plan libraries");

• jmeter-maven-plugin/src/main/java/com/lazerycode/jmeter/mojo/ConfigureJMeterMojo.java

  Line 458 in e948c05

  copyExplicitLibrary(desiredArtifact, destination, downloadDependencies);

• jmeter-maven-plugin/src/main/java/com/lazerycode/jmeter/mojo/ConfigureJMeterMojo.java

  Line 473 in e948c05

  resolveTestDependenciesAndCopyWithTransitivity(returnedArtifact);

• jmeter-maven-plugin/src/main/java/com/lazerycode/jmeter/mojo/ConfigureJMeterMojo.java

  Lines 504 to 505 in e948c05

  	// Here we can not filter dependencies by scope, we need to use dependencies with any scope
  	// This is because JMeter tests use test, provided, and compile-scoped dependencies

In other words, because "JMeter tests use test, provided, and compile-scoped dependencies", and the resolveTestDependenciesAndCopyWithTransitivity is reused, that method isn't flexible enough to handle ONLY bringing in compile dependencies related to the testPlanLibraries, and ALL transitive dependencies from ALL scopes for the other types of JMeter dependencies...

[YerayBrito]

as we are currently facing the same => there is a possibility to solve that by combining a set of plugins and a small copy script and binding this to maven phases, e.g. a POM to copy Faker and the Maria driver lib

    <profiles>
        <profile>
            <id>dev</id>
            <activation>
                <activeByDefault>true</activeByDefault>
            </activation>
            <properties>
                <e2e-stage>dev</e2e-stage>
            </properties>
        </profile>
    </profiles>

    <dependencies>
        <dependency>
            <groupId>com.github.javafaker</groupId>
            <artifactId>javafaker</artifactId>
            <version>1.0.2</version>
        </dependency>
        <dependency>
            <groupId>org.mariadb.jdbc</groupId>
            <artifactId>mariadb-java-client</artifactId>
            <version>3.1.4</version>
        </dependency>
    </dependencies>

    <build>
        <plugins>
            <plugin>
                <groupId>com.lazerycode.jmeter</groupId>
                <artifactId>jmeter-maven-plugin</artifactId>
                <version>3.6.1</version>
                <executions>
                    <execution>
                        <id>default-cli</id>
                        <phase>compile</phase>
                        <goals>
                            <goal>configure</goal>
                        </goals>
                    </execution>
                    <execution>
                        <id>jmeter-tests</id>
                        <phase>integration-test</phase>
                        <goals>
                            <goal>jmeter</goal>
                        </goals>
                    </execution>
                    <execution>
                        <id>jmeter-check-results</id>
                        <phase>verify</phase>
                        <goals>
                            <goal>results</goal>
                        </goals>
                    </execution>
                </executions>
                <configuration>
                    <generateReports>true</generateReports>
                    <customPropertiesFiles>
                        <file>${basedir}/src/test/resources/${e2e-stage}.properties</file>
                    </customPropertiesFiles>
                </configuration>
            </plugin>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-dependency-plugin</artifactId>
                <version>3.6.0</version>
                <executions>
                    <execution>
                        <id>copy-dependencies</id>
                        <phase>generate-test-resources</phase>
                        <goals>
                            <goal>copy-dependencies</goal>
                        </goals>
                        <configuration>
                            <excludeGroupIds>org.slf4j</excludeGroupIds>
                            <excludeGroupIds>net.java.dev.jna</excludeGroupIds>
                        </configuration>
                    </execution>
                </executions>
            </plugin>
            <plugin>
                <groupId>org.codehaus.mojo</groupId>
                <artifactId>exec-maven-plugin</artifactId>
                <version>3.1.0</version>
                <executions>
                    <execution>
                        <id>copy-to-jmeter-libs</id>
                        <phase>process-test-resources</phase>
                        <goals>
                            <goal>exec</goal>
                        </goals>
                    </execution>
                </executions>
                <configuration>
                    <executable>${basedir}/scripts/copy-dependencies.sh</executable>
                </configuration>
            </plugin>
        </plugins>
    </build>

the copy script to use to call by the exec goal

#!/bin/sh

target=$(jq -r '.configurations[0].jmeterDirectoryPath' target/config.json)
cp -av target/dependency/* "$target/lib"