JUnit5 integration results in "1 containers skipped" #371

Closed
estekhin opened this Issue Dec 13, 2016 · 0 comments

Projects

None yet

2 participants

@estekhin

Using JUnit5 M3, JMockit 1.29.

After running the tests I got statistics similar to this:

Test run finished after 14125 ms
[       435 containers found      ]
[         1 containers skipped    ]
...

That "1 containers skipped" is due to https://github.com/jmockit/jmockit1/blob/0555670e950cd2ac756eee8539390d1cc46a31cf/main/src/mockit/integration/junit5/JMockitTestEngine.java#L53.

I am not sure what the correct semantics should be in that case, but "skipped container" looks somewhat baffling when there are no tests or tests classes explicitly marked as skipped or disabled, and the test suite is green.

Please consider replacing executionSkipped() with a sequence of executionStarted() immediately followed by executionFinished(..., TestExecutionResult.successful()).

@rliesenfeld rliesenfeld self-assigned this Dec 13, 2016
@rliesenfeld rliesenfeld added a commit that closed this issue Dec 13, 2016
@rliesenfeld rliesenfeld Fixed JUnit 5 integration, which was erroneously causing test executi…
…ons to count as "skipped"; closes #371.
9db42ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment