Thrown UnexpectedInvocation exception turns partially mocks into strict mocks

[borisbrodski]

JMockit: 1.10

Here is a code snippet

import java.math.BigDecimal;

import mockit.NonStrictExpectations;
import mockit.internal.UnexpectedInvocation;

import org.junit.Test;

public class Test1 {
    @Test
    public void test1() {
        new NonStrictExpectations(BigDecimal.class) {{
            new BigDecimal(0).intValue();
            result = 1;
            maxTimes = 2;
        }};

        BigDecimal bigDecimal = BigDecimal.valueOf(0); // Invocation OK
        bigDecimal.intValue();
        bigDecimal.intValue();

        BigDecimal.valueOf(0);  // Invocation still OK

        try {
            bigDecimal.intValue();
        } catch (UnexpectedInvocation e) {

        }

        BigDecimal.valueOf(0);  // Unexpected invocation!!
    }
}

As you can see, til UnexpectedInvocation was thrown the BigDecimal class was partially mocked. But after UnexpectedInvocation was thrown BigDecimal turns into non-partially and also strict mocked class.

[Varun200864]

Exception is thrown by third call of bigDecimal.intValue().

[borisbrodski]

Yes, but this exception is catched and ignored. If you remove the last line of the test

BigDecimal.valueOf(0); // Unexpected invocation!!

the test will be green.

[Varun200864]

You are right.
If you comment third call of bigDecimal.intValue() then also it is green.

[borisbrodski]

Of course you are right:)

But still I would consider this a bug. In all other cases I was able to catch JMockit exceptions and proceed just normally.

Background: Currently I'm working on the JMockit-Xtend bridge (https://github.com/borisbrodski/jmockit-xtend). In order to test it, I have to do such "crazy" things, like producing errors and then catch the JMockit exceptions.

[Varun200864]

I agree with you, This may be a bug.
The test is green if you change the code to

final BigDecimal bigDecimal1 = new BigDecimal(0);
new Expectations(BigDecimal.class) {{
bigDecimal1.intValue();
result = 1;
maxTimes = 2;
}};

[rliesenfeld]

Yes, the test fails on JMockit 1.10, indicating a bug. But on JMockit 1.11, it passes, so I suppose this is already fixed.

Anyways, thanks for the report!

[Varun200864]

This is working with JMockit 1.11. Thank you.

[rliesenfeld]

I closed this too soon; there was indeed a bug to fix.