New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basque translation #2131

Merged
merged 3 commits into from Jul 9, 2018

Conversation

Projects
None yet
3 participants
@aldatsa
Contributor

aldatsa commented Jun 26, 2018

Would be great if you could include in your next release!

@aldatsa aldatsa referenced this pull request Jun 26, 2018

Merged

Add Basque translation #254

@jguille2

This comment has been minimized.

Show comment
Hide comment
@jguille2

jguille2 Jun 26, 2018

Contributor

Kaixo Asier,
Eta eskerrik asko!

Just two comments to finish your translation work...

  • You must also update locale.js file to add Euskara to the Snap! languages. Right to the end and add
SnapTranslator.dict.eu = {
    'language_name':
        'Euskara',
    'language_translator':
        'Asier Iturralde',
    'translator_e-mail':
        'mail?',
    'last_changed':
        '2018-06-26'
};

(with a public email)

  • Edit your lang-eu.js to fix lines 724 and 725 (it is for a recent change in Snap!)
    'letter %n of %s':
        '%n . letra hemendik %s',

must change to

    'letter %idx of %s':
        '%idx . letra hemendik %s',

That's all!
Agur!

Joan

Contributor

jguille2 commented Jun 26, 2018

Kaixo Asier,
Eta eskerrik asko!

Just two comments to finish your translation work...

  • You must also update locale.js file to add Euskara to the Snap! languages. Right to the end and add
SnapTranslator.dict.eu = {
    'language_name':
        'Euskara',
    'language_translator':
        'Asier Iturralde',
    'translator_e-mail':
        'mail?',
    'last_changed':
        '2018-06-26'
};

(with a public email)

  • Edit your lang-eu.js to fix lines 724 and 725 (it is for a recent change in Snap!)
    'letter %n of %s':
        '%n . letra hemendik %s',

must change to

    'letter %idx of %s':
        '%idx . letra hemendik %s',

That's all!
Agur!

Joan

@jmoenig

This comment has been minimized.

Show comment
Hide comment
@jmoenig

jmoenig Jun 26, 2018

Owner

Thank you, @aldatsa ! I will pull this for the next minor release which I really want to do as soon as my schedule permits. Also, thank you, @jguille2 , for the explanations about what we should change. Don't worry, if you don't find the time to add these changes yourself, @aldatsa , I will gladly do these myself when I pull your request.

This is great! I can't wait for Basque children to be able to use Snap! in their native language!

Owner

jmoenig commented Jun 26, 2018

Thank you, @aldatsa ! I will pull this for the next minor release which I really want to do as soon as my schedule permits. Also, thank you, @jguille2 , for the explanations about what we should change. Don't worry, if you don't find the time to add these changes yourself, @aldatsa , I will gladly do these myself when I pull your request.

This is great! I can't wait for Basque children to be able to use Snap! in their native language!

@aldatsa

This comment has been minimized.

Show comment
Hide comment
@aldatsa

aldatsa Jun 27, 2018

Contributor

Eskerrik asko bioi zuen laguntzagatik! Thank you both for your help!

Contributor

aldatsa commented Jun 27, 2018

Eskerrik asko bioi zuen laguntzagatik! Thank you both for your help!

@jmoenig jmoenig merged commit 8a43b00 into jmoenig:master Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment