New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed empty_iter dependency #11

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
@hassa

hassa commented Dec 6, 2012

Django 1.5 does not have the compiler. empty_iter function, they directly use

iter([])

instead. This commit covers that.

@ebrelsford

This comment has been minimized.

ebrelsford commented Mar 4, 2013

1.5 support would be nice. @jmoiron and @hassa, let me know if there is some way I can help make it happen.

@hassa

This comment has been minimized.

hassa commented Mar 4, 2013

@ebrelsford, last time we tried running johnny with 1.5 the commit above worked, not sure about now though since we stopped using it a while ago.

@ebrelsford

This comment has been minimized.

ebrelsford commented Mar 4, 2013

Thanks, @hassa, I'm running it against Django 1.5 without any problems.

@dlo

This comment has been minimized.

dlo commented Mar 5, 2013

Would be really awesome to have this merged in. Since 1.5 is now the current version, I think getting a release out with this patch is pretty crucial, or else johnny-cache won't work on any new apps.

@borgstrom

This comment has been minimized.

borgstrom commented Mar 11, 2013

We just ran into this in a project we're in development on.

+1 on getting this merged ASAP.

@markekramer

This comment has been minimized.

markekramer commented Mar 11, 2013

I have validated this patch and deployed. Solves the problem. The empty_iter exception is easily recreated when using pagination and an empty set is returned. Again, this patch fixes that issue.

@dlo

This comment has been minimized.

dlo commented Mar 11, 2013

I have also validated this patch and used it in production.

@natethelen

This comment has been minimized.

natethelen commented Mar 20, 2013

Me too!

@borgstrom

This comment has been minimized.

borgstrom commented Mar 20, 2013

@jmoiron can you please merge this? Django 1.5 has been out for nearly 2 months now and using a manually patched version of johnny cache for each build we're working on is a PITA.

@jself

This comment has been minimized.

Collaborator

jself commented Mar 25, 2013

Thanks all, it's merged, but we preserved 1.4 support as well with compiler.empty_iter. Pypi will be updated after we clear the other tickets.

@jself jself closed this Mar 25, 2013

@borgstrom

This comment has been minimized.

borgstrom commented Apr 3, 2013

@finder any update on a pypi release? Anything I can do to help it along?

@jmoiron

This comment has been minimized.

Owner

jmoiron commented Apr 3, 2013

I really wanted to implement the deprecation policy before a new push. The 1.1 removal has been done by @finder, but there are a few outstanding critical bugs before a release. However, 1.5.1 is nearly out, and you're right it's past time to release some of these improvements. I haven't been able to find time to work on the release but I'll try to get around to it this week.

@avelino

This comment has been minimized.

avelino commented Apr 19, 2013

@jmoiron what needs to be released? I can help!

@Wilfred

This comment has been minimized.

Contributor

Wilfred commented Aug 2, 2013

@jmoiron @finder which tickets need to be fixed before release? There are even Django 1.6 issues in the tracker now.

@vchakoshy

This comment has been minimized.

vchakoshy commented Sep 9, 2013

i disabled johnny cache in django 1.5,

@famoraes

This comment has been minimized.

famoraes commented Oct 10, 2013

👍 Would be great if the Pypi was updated.

@davesque

This comment has been minimized.

davesque commented Jan 24, 2014

Yes, please update Pypi.

@ckcollab

This comment has been minimized.

ckcollab commented Feb 6, 2014

@jmoiron Any expected Pypi release? If you need help please let us know!

@ivorbosloper

This comment has been minimized.

ivorbosloper commented Feb 26, 2014

Would be great if Pypi was updated! 1.5 is not that new any more...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment