New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed empty_iter dependency #11
Conversation
@ebrelsford, last time we tried running johnny with 1.5 the commit above worked, not sure about now though since we stopped using it a while ago. |
Thanks, @hassa, I'm running it against Django 1.5 without any problems. |
Would be really awesome to have this merged in. Since 1.5 is now the current version, I think getting a release out with this patch is pretty crucial, or else johnny-cache won't work on any new apps. |
We just ran into this in a project we're in development on. +1 on getting this merged ASAP. |
I have validated this patch and deployed. Solves the problem. The empty_iter exception is easily recreated when using pagination and an empty set is returned. Again, this patch fixes that issue. |
I have also validated this patch and used it in production. |
Me too! |
@jmoiron can you please merge this? Django 1.5 has been out for nearly 2 months now and using a manually patched version of johnny cache for each build we're working on is a PITA. |
Thanks all, it's merged, but we preserved 1.4 support as well with compiler.empty_iter. Pypi will be updated after we clear the other tickets. |
@finder any update on a pypi release? Anything I can do to help it along? |
I really wanted to implement the deprecation policy before a new push. The 1.1 removal has been done by @finder, but there are a few outstanding critical bugs before a release. However, 1.5.1 is nearly out, and you're right it's past time to release some of these improvements. I haven't been able to find time to work on the release but I'll try to get around to it this week. |
@jmoiron what needs to be released? I can help! |
i disabled johnny cache in django 1.5, |
👍 Would be great if the Pypi was updated. |
Yes, please update Pypi. |
@jmoiron Any expected Pypi release? If you need help please let us know! |
Would be great if Pypi was updated! 1.5 is not that new any more... |
Django 1.5 does not have the compiler. empty_iter function, they directly use
instead. This commit covers that.