Changes for v1.3.0 sqlx.In

[johejo]

In v1.3.0, sqlx.In returns slice of pointer.

package sqlx_test

import (
	"testing"

	"github.com/jmoiron/sqlx"
)

func TestIn_130(t *testing.T) {
	t.Run("[]interface{}{}", func(t *testing.T) {
		q, args, err := sqlx.In("SELECT * FROM people WHERE name IN (?)", []interface{}{[]string{"gopher"}}...)
		if err != nil {
			t.Fatal(err)
		}
		if q != "SELECT * FROM people WHERE name IN (?)" {
			t.Errorf("got=%v", q)
		}
		t.Log(args)
		for _, a := range args {
			switch a.(type) {
			case string:
				t.Log("ok: string", a)
			case *string:
				t.Error("ng: string pointer", a, *a.(*string))
			}
		}
	})

	t.Run("[]string{}", func(t *testing.T) {
		q, args, err := sqlx.In("SELECT * FROM people WHERE name IN (?)", []string{"gopher"})
		if err != nil {
			t.Fatal(err)
		}
		if q != "SELECT * FROM people WHERE name IN (?)" {
			t.Errorf("got=%v", q)
		}
		t.Log(args)
		for _, a := range args {
			switch a.(type) {
			case string:
				t.Log("ok: string", a)
			case *string:
				t.Error("ng: string pointer", a, *a.(*string))
			}
		}
	})
}

This test passes in v1.2.0 but fails in v1.3.0.

related #635

[jmoiron]

Thanks, hyrum's law strikes again, I'll add this as a test and see if I need to back that optimization change out.

[njern]

@jmoiron are you planning to cut a 1.3.1 release with this fix included?