Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete handlebars support #737

Closed
NLincoln opened this issue Aug 1, 2017 · 3 comments
Closed

Incomplete handlebars support #737

NLincoln opened this issue Aug 1, 2017 · 3 comments
Labels
bugfix-request A request for a bugfix to be developed. pr-open A PR addressing this issue is open.

Comments

@NLincoln
Copy link

NLincoln commented Aug 1, 2017

From https://gitlab.com/gitlab-org/gitlab-ce/issues/35782

<div data-test-id={{user.id}}>
  {{user.username}}
</div>

Everything from the ending > on the first line to the {{ on the 2nd line is marked as invalid syntax.

{{user-model onSave=(action 'afterSave')}}

the parens around the action helper are marked as invalid

{{#user-model as |user|}}
 {{user.username}}
{{/user-model}}

The |'s around user are marked invalid
jlemaes pushed a commit to jlemaes/rouge that referenced this issue Apr 22, 2018
Better handlebars support rouge-ruby#737
eec82d7
jlemaes pushed a commit to jlemaes/rouge that referenced this issue Apr 22, 2018
Better handlebars support rouge-ruby#737
69ed357
@jlemaes jlemaes mentioned this issue Apr 22, 2018
Merged
@stale
Copy link

stale bot commented Jun 19, 2019

This contribution has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.

@stale stale bot added the stale-issue There has been no activity for a year. label Jun 19, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jun 19, 2019

Sorry, this has an associated PR open and shouldn't have been marked as stale. That's been fixed.

@stale stale bot removed the stale-issue There has been no activity for a year. label Jun 19, 2019
@pyrmont pyrmont added bugfix-request A request for a bugfix to be developed. pr-open A PR addressing this issue is open. labels Jun 19, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jul 18, 2019

This has been fixed via #899.

@pyrmont pyrmont closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugfix-request A request for a bugfix to be developed. pr-open A PR addressing this issue is open.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pyrmont @NLincoln