Initial Biml Lexer support #415

Merged
merged 5 commits into from Jun 2, 2016

Conversation

Projects
None yet
2 participants
@japj
Contributor

japj commented Mar 2, 2016

This is the initial support for BIML highlighting.

This initial version is based of the XML Lexer with the additional support for dealing with <# style parts and then delegating to the CSharp Lexer.

The only thing I have not figured out yet is how to correctly handle the embedded <# handling inside an xml attribute value string, i.e. (this one is currently rendered wrong).

I hope this is acceptable as a first version, if not then just let me know what needs to be fixed

@japj

This comment has been minimized.

Show comment
Hide comment
@japj

japj Mar 2, 2016

Contributor

Ok, I just discovered there might be an UTF8 encoding issue in the biml sample files, looking into that

Contributor

japj commented Mar 2, 2016

Ok, I just discovered there might be an UTF8 encoding issue in the biml sample files, looking into that

@japj

This comment has been minimized.

Show comment
Hide comment
@japj

japj Mar 2, 2016

Contributor

Fixed the UTF8 issue in #417

Contributor

japj commented Mar 2, 2016

Fixed the UTF8 issue in #417

@jneen

This comment has been minimized.

Show comment
Hide comment
@jneen

jneen Jun 2, 2016

Owner

Awesome, this looks great! Just two things before I merge:

  • Please use 2-space indentation for all the ruby files.
  • Please add newlines at the end of each file.
Owner

jneen commented Jun 2, 2016

Awesome, this looks great! Just two things before I merge:

  • Please use 2-space indentation for all the ruby files.
  • Please add newlines at the end of each file.
@japj

This comment has been minimized.

Show comment
Hide comment
@japj

japj Jun 2, 2016

Contributor

Thanks for the feedback and sorry for not catching that myself earlier.
I updated the pull request, but apparently the utf8 fix got pulled into this aswell.
I don't think that should be a problem though since you already merged it?

Contributor

japj commented Jun 2, 2016

Thanks for the feedback and sorry for not catching that myself earlier.
I updated the pull request, but apparently the utf8 fix got pulled into this aswell.
I don't think that should be a problem though since you already merged it?

@jneen

This comment has been minimized.

Show comment
Hide comment
@jneen

jneen Jun 2, 2016

Owner

Should be fine. Worst case is an extra no-op commit.

Owner

jneen commented Jun 2, 2016

Should be fine. Worst case is an extra no-op commit.

@jneen jneen merged commit 8186ad6 into jneen:master Jun 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jneen

This comment has been minimized.

Show comment
Hide comment
@jneen

jneen Jun 6, 2016

Owner

Released in v1.11.0.

Owner

jneen commented Jun 6, 2016

Released in v1.11.0.

@japj japj deleted the japj:biml branch Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment