Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jn/swift 5.0 #8

Merged
merged 18 commits into from Apr 5, 2019

Conversation

@jnewc
Copy link
Owner

commented Apr 5, 2019

No description provided.

jnewc added some commits Feb 5, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 5, 2019

Codecov Report

Merging #8 into master will increase coverage by 1.7%.
The diff coverage is 90.9%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master      #8     +/-   ##
========================================
+ Coverage    91.3%   93.1%   +1.7%     
========================================
  Files          25      25             
  Lines         418     424      +6     
========================================
+ Hits          382     395     +13     
+ Misses         36      29      -7
Impacted Files Coverage Δ
Sources/Cosmic/Base/Logger.swift 100% <100%> (ø) ⬆️
Sources/Cosmic/Base/LogReporter.swift 100% <100%> (ø) ⬆️
Sources/Cosmic/Formatters/JSONFormatter.swift 94.7% <80%> (-5.3%) ⬇️
Sources/Cosmic/Formatters/SyslogFormatter.swift 80% <0%> (-20%) ⬇️
Sources/Cosmic/Utilities/UniversalSocket.swift 98.3% <0%> (+3.3%) ⬆️
Sources/Cosmic/Socket/SocketLogger.swift 73.8% <0%> (+4.7%) ⬆️
Sources/Cosmic/Socket/Services/LogglyLogger.swift 100% <0%> (+9%) ⬆️
Sources/Cosmic/Socket/Services/LogItLogger.swift 100% <0%> (+17.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed4946...46544e7. Read the comment docs.

jnewc added some commits Apr 5, 2019

@jnewc

This comment has been minimized.

Copy link
Owner Author

commented Apr 5, 2019

Codecov is ignoring the hardcoded coverage target. Merging.

@jnewc jnewc merged commit 6c5296f into master Apr 5, 2019

2 of 3 checks passed

codecov/patch 90.9% of diff hit (target 91.3%)
Details
codecov/project 93.1% (target 90%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jnewc jnewc deleted the feature/jn/swift-5.0 branch Apr 5, 2019

@jnewc jnewc restored the feature/jn/swift-5.0 branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.