New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify jni_x_call macro names #123
Comments
I assume the macros are now a part of the public API of the crate: Lines 208 to 209 in d4ed1b3
Shan't we make it private? |
I see no reason to make these specific macros public. |
Yeah, that's rather an implementation detail — and if some JNI methods are missing, it probably makes sense to add them in this library. |
Updated the description |
I've mistaken the definition — these macros aren't actually exported 🙃 |
Clarify the naming to express behaviour more precisely:
jni_non_null_call
must probably bejni_non_void_call
— as it does not check its return value to be non-nulljni_call
must bejni_non_null_call
— as it works for pointer/references only and checks its return value to be non-null.not_null
→null_to_err
, see the discussion: Further improvements of macro usage for JNI calls #150 (comment)The text was updated successfully, but these errors were encountered: