update for windows #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests for generic_filter and generic_filter1d
jni
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
Thank you! 🎉
Ideally, tests should show that jitted and unjitted results are the same, but given that we had exactly 0 tests before this, I'm going to just merge and create issues about improving our testing.
Thanks so much for figuring out this longstanding issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix windows signature bug with platform specific call.
Added tests for generic_filter and generic_filter1d
Hiya,
I had a go at improving these for windows. I've added a platform test because I didn't want to affect the behaviour on Linux where the code is working. I also added a few simple tests to make sure the code runs using
pytest. I haven't used geometric_filter before so I've left that for someone who know better what they are doing.