Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #139

Merged
merged 19 commits into from
Nov 13, 2021
Merged

Fix CI #139

merged 19 commits into from
Nov 13, 2021

Conversation

jni
Copy link
Owner

@jni jni commented Nov 8, 2021

No description provided.

jni added 19 commits November 8, 2021 02:53
@jni jni marked this pull request as ready for review November 13, 2021 01:59
@jni
Copy link
Owner Author

jni commented Nov 13, 2021

@kevinyamauchi 🎉 😭 🎉

@jni jni changed the title WIP: try to fix CI Fix CI Nov 13, 2021
@jni jni merged commit 7450734 into master Nov 13, 2021
@jni
Copy link
Owner Author

jni commented Nov 13, 2021

(The key was c756352. For some reason, pip copied the tests folder to the installation directory locally, but not on CI. Still don't know why, but adding the __init__.py fixed it! Everything else is just fiddling at the margins.)

@jni jni deleted the fix-ci branch November 13, 2021 02:06
@kevinyamauchi
Copy link
Collaborator

Wow, amazing! This is a nice surprise to wake up to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jni @kevinyamauchi