-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sholl analysis for Skeleton object #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was thinking the following changes:
|
Thanks for the comments @kushaangupta! Both good suggestions, I've implemented them. |
* Center-terminal distance for auto-init * Improve identifiers
This allows us to capture processes that loop back on themselves. Also, using the norm of the spacing as the default step size allows us to compare analyses over different images with the same parameters.
Cool, this just needs a couple of tests and is ready to go in I think...! |
Oh great work! Sorry, I couldn't work on it. Got a bit confused trying to make tutorial notebook on it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #148
@kushaangupta could you please continue your work in a new branch starting from this one? To add a documentation page, you can write it in myst-nb syntax (or export a notebook to that syntax). We'll update the docs infrastructure in a different PR to make sure that gets rendered correctly in the site.