Skip to content

Drop Python 3.7 support - #167

Merged
jni merged 4 commits into
jni:mainfrom
kushaangupta:drop-py-37
Apr 17, 2022
Merged

Drop Python 3.7 support#167
jni merged 4 commits into
jni:mainfrom
kushaangupta:drop-py-37

Conversation

@kushaangupta

Copy link
Copy Markdown
Contributor

Closes #165

@jni

jni commented Apr 6, 2022

Copy link
Copy Markdown
Owner

Thanks @kushaangupta! We should also:

  • add 3.10 to the list
  • update the test builds in .github/workflows to not build 3.7 and build 3.10.

@kushaangupta

Copy link
Copy Markdown
Contributor Author

Weirdly, the workflow job is interpreting 3.10 as 3.1 leading to the failures.

@jni

jni commented Apr 17, 2022

Copy link
Copy Markdown
Owner

Ah yes this was a common error, you need to write "3.10" in quotes so that it is interpreted as a string rather than a float.

@jni
jni merged commit 5f9b23f into jni:main Apr 17, 2022
@jni

jni commented Apr 17, 2022

Copy link
Copy Markdown
Owner

Thank you! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Py 3.7 support

2 participants