Skip to content

Drop Python 3.7 support #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2022
Merged

Drop Python 3.7 support #167

merged 4 commits into from
Apr 17, 2022

Conversation

kushaangupta
Copy link
Contributor

Closes #165

@jni
Copy link
Owner

jni commented Apr 6, 2022

Thanks @kushaangupta! We should also:

  • add 3.10 to the list
  • update the test builds in .github/workflows to not build 3.7 and build 3.10.

@kushaangupta
Copy link
Contributor Author

Weirdly, the workflow job is interpreting 3.10 as 3.1 leading to the failures.

@jni
Copy link
Owner

jni commented Apr 17, 2022

Ah yes this was a common error, you need to write "3.10" in quotes so that it is interpreted as a string rather than a float.

@jni jni merged commit 5f9b23f into jni:main Apr 17, 2022
@jni
Copy link
Owner

jni commented Apr 17, 2022

Thank you! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Py 3.7 support
2 participants
@kushaangupta @jni