Skip to content

DOC Add versions and use pydata theme#173

Merged
jni merged 18 commits into
jni:mainfrom
lucyleeow:doc_versions
Jun 2, 2022
Merged

DOC Add versions and use pydata theme#173
jni merged 18 commits into
jni:mainfrom
lucyleeow:doc_versions

Conversation

@lucyleeow

Copy link
Copy Markdown
Collaborator

Comment thread .github/workflows/deploy-docs.yml Outdated

- name: Deploy stable docs 🚀
uses: JamesIves/github-pages-deploy-action@4.1.5
if: startsWith(${{ github.ref_name }}, 'v*')

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Comment on lines +30 to +31
DOC_DIR="$(cut -d '.' -f 1,2 <<< "$TAG")"
echo "DOC_DIR=${DOC_DIR:1}".x >> $GITHUB_ENV

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't figure out how to make this a one liner, suggestions welcome. Works as is and outputs e.g., "0.1.x"

Comment thread doc/_static/version_switcher.json Outdated
[
{
"version": "0.1.x",
"url": "https://jni.github.io/skan/0.1.x"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how the url's work so not sure if this works, pydata docs didn't expand. @jni can you explain..?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably can replace this with skeleton-analysis.org instead of jni.github.io/skan. But I think both will work, because jni.github.io/skan/whatever.html automatically resolves to skeleton-analysis.org/whatever.html. In fact what you've got is probably the optimum choice because it'll be stable even if the domain lapses.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each of these we need to go back and build the old docs though, and the early versions are pointless. I would say let's go back to 0.7.x and no more, as that is the version matching the paper.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept jni.github.io/skan because that is what is used everywhere else in the config file. So keep as is then?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

Comment thread requirements/doc.txt
@lucyleeow

Copy link
Copy Markdown
Collaborator Author

Supposedly subsections should be in the left navigation bar by default.

but it seems to be at the top?

image

I think I have removed all alabaster config lines and hopefully it should be a default build of pydata theme now

@lucyleeow lucyleeow changed the title WIP DOC Add versions and use pydata theme DOC Add versions and use pydata theme Jun 1, 2022
Comment thread doc/conf.py
'repo_url': 'https://github.com/jni/skan/',
'repo_name': 'Skan',

# Visible levels of the global TOC; -1 means unlimited

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be from alabaster theme

@lucyleeow

Copy link
Copy Markdown
Collaborator Author

I think this is ready for review and merge. I thought it would be best to get this in first before doing the branch 0.10.x, as we want the version switcher json file in gh-pages

@lucyleeow

Copy link
Copy Markdown
Collaborator Author

I've realised I need to fix version matching here.

@jni jni left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🔥

@jni jni merged commit 2d8f12c into jni:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants