cache skeleton_image shape for path_label_image#210
Merged
Conversation
Contributor
Author
|
Really only the last commit is important since I reverted once to fix the diff. I can create a new pull request with only those changes if preferred |
jni
approved these changes
Aug 14, 2023
Owner
|
I typically squash when merging @jarodhanko-crafco so no need to open new PR. Optionally, would you mind adding a test to ensure this issue doesn't reoccur? I'm happy to push to this branch if it's not clear how to do that. |
Owner
|
Thanks for this fix @jarodhanko-crafco! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may be possible to update prune_paths to use this as well if the skeleton_image is None (basically create new image and add paths that are not to be pruned), but for now now that is being left as is.
Resolves Issue #208