2.4 stable #1499
Closed
2.4 stable #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo
…hat can become a string
It is convenient to be able to pass in URI objects to `visit`, but these need to be coerced to a string before actual usage. Most of visit's code paths would convert the incoming url to a string as-needed. However, the path used when `always_include_port` is enabled did not, causing an error where `URI.parse` would try to parse an existing URI object. This change consolidates the coercion to string at the entrypoint of the method.
check correct version string for rspec composable
…EADME due to issue #1419
This test had a hardcoded values for the URI to visit which varies for different test cases. When these specs are integrated in custom driver's test suite like capybara-mechanize, it leads to failures. This replaces #1227, which was rejected for changing the original purpose of the test. However, this patch only changes the hardcoding. It will allow phillbaker/capybara-mechanize#55 to proceed and bump it's compatibility to beyond capybara 2.1.
|
What is the reason for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.