Suppress warnings #897

Merged
merged 5 commits into from Dec 2, 2012

2 participants

@kou
kou commented Dec 2, 2012

Those changes suppresses warnings that are found by the following command:

% ruby -w -S rspec ./spec/basic_node_spec.rb ./spec/capybara_spec.rb ./spec/dsl_spec.rb ./spec/rack_test_spec.rb ./spec/result_spec.rb ./spec/rspec/features_spec.rb ./spec/rspec/matchers_spec.rb ./spec/rspec_spec.rb ./spec/server_spec.rb --color

Here is a list of suppressed warnings:

lib/capybara/spec/spec_helper.rb:49: warning: shadowing outer local variable - name
lib/capybara/spec/spec_helper.rb:49: warning: shadowing outer local variable - options
lib/capybara/selector.rb:48: warning: instance variable @label not initialized
lib/capybara/session.rb:170: warning: instance variable @server not initialized
lib/capybara/node/base.rb:101: warning: instance variable @unsynchronized not initialized
lib/capybara/session.rb:74: warning: instance variable @touched not initialized
kou added some commits Dec 2, 2012
@kou kou Suppress warnings: shadowing outer local variable
lib/capybara/spec/spec_helper.rb:49: warning: shadowing outer local variable - name
lib/capybara/spec/spec_helper.rb:49: warning: shadowing outer local variable - options
180f3dc
@kou kou Suppress a warning: instance variable @label not initialized
lib/capybara/selector.rb:48: warning: instance variable @label not initialized
599856f
@kou kou Suppress a warning: instance variable @server not initialized
lib/capybara/session.rb:170: warning: instance variable @server not initialized
d9818a8
@kou kou Suppress a warning: instance variable @unsynchronized not initialized
lib/capybara/node/base.rb:101: warning: instance variable @unsynchronized not initialized
8bfb813
@kou kou Suppress a warning: instance variable @touched not initialized
lib/capybara/session.rb:74: warning: instance variable @touched not initialized
cb8543f
@joliss
Collaborator

Thanks!

(Not to worry about the failing Travis build - it's an unrelated issue that we still need to track down.)

@joliss joliss merged commit 67a78f4 into jnicklas:master Dec 2, 2012

1 check failed

Details default The Travis build failed
@amatsuda amatsuda referenced this pull request Jul 21, 2015
Merged

Ruby warnings #1552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment