Catch the correct timeout exception during Server#boot #918

Merged
merged 1 commit into from Dec 26, 2012

Projects

None yet

2 participants

@jdelStrother

TimeoutError is actually Capybara::TimeoutError, which is unrelated to Ruby's Timeout. I think this is left over from back when we used to use Capybara.timeout {... } while booting the server.

Capybara::TimeoutError could perhaps be removed now - it's only used as the superclass of InfiniteRedirectError. WDYT?

@jdelStrother jdelStrother Catch the correct timeout exception during Server#boot
TimeoutError is actually Capybara::TimeoutError, which is unrelated to Ruby's Timeout
13bca79
@jnicklas jnicklas merged commit 00df18a into jnicklas:master Dec 26, 2012

1 check was pending

Details default The Travis build is in progress
@jnicklas
Owner

Indeed, we should remove the error class as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment