Jonas Nicklas jnicklas

Organizations

@elabs @got-js @carrierwaveuploader
jnicklas commented on pull request elabs/pundit#279
@jnicklas

Nice!

@jnicklas
jnicklas merged pull request elabs/pundit#279
@jnicklas
NotAuthorizedError can be initialized with a string
1 commit with 16 additions and 5 deletions
@jnicklas
jnicklas commented on issue refile/refile#6
@jnicklas

I just modified #211 to add a append: true|false config option, which default to false, contrary to what I first suggested. I'm going with the "all…

jnicklas commented on pull request refile/refile#211
@jnicklas

Fixed, thanks :)

@jnicklas
@jnicklas
  • @jnicklas 30b710b
    Override the existing files on multiple file upload.
jnicklas commented on issue refile/refile#6
@jnicklas

@brandoncc thank you for your thoughtful input. I'll mull it over a bit.

jnicklas commented on issue refile/refile#6
@jnicklas

@brandoncc I think that making question (3) configurable would not add a lot of complexity. On the other hand, making question (2) configurable is …

jnicklas commented on issue refile/refile#208
@jnicklas

It used to be that we actually took into account request-specific information in the helper, which is why we made it a helper. But we don't do that…

jnicklas commented on issue refile/refile#6
@jnicklas

@brandoncc thank you for your well thought-out feedback. You make a good point about the second argument, I'm also on the fence, and I think there'…

jnicklas commented on issue refile/refile#204
@jnicklas

This is specifically something that Refile is not going to do. You can create a helper for this something like thumbnail_image for example, or what…

@jnicklas
Consider carrierwave-esque DSL for version naming
jnicklas opened pull request refile/refile#211
@jnicklas
Add support for multiple attachments
10 commits with 508 additions and 45 deletions
@jnicklas
  • @jnicklas 9ef05e4
    Clarify validations and constraints
@jnicklas
  • @jnicklas b4f5102
    Add README section about multiple file uploads
@jnicklas
@jnicklas
jnicklas commented on pull request refile/refile#202
@jnicklas

Done!

@jnicklas
jnicklas merged pull request refile/refile#202
@jnicklas
Split part of Attacher off into AttachmentDefinition
1 commit with 104 additions and 48 deletions
jnicklas commented on issue refile/refile#6
@jnicklas

Another question: When editing a record and uploading multiple files via this method, should the new files be appended to the list of associated fi…

jnicklas commented on issue refile/refile#6
@jnicklas

A question for people on this thread: I've started working on this, it's coming along nicely. However, I ran into some design decisions I'm unsure …

@jnicklas
jnicklas commented on issue refile/refile#185
@jnicklas

@fiedl since we can't repro this, we really need your help in tracking down the source of the issue. If you want to get this issue resolved, you'll…

jnicklas commented on pull request refile/refile#210
@jnicklas

@aglushkov personally I find option (1) better.

jnicklas commented on pull request elabs/pundit#277
@jnicklas

@srecnig yes, please!

jnicklas commented on issue refile/refile#185
@jnicklas

@fiedl can you track down why this is happening? I can't repro it at all, so I really can't help with solving it.

@jnicklas

It's also inconsistent between matching a query parameter, which makes the extraction match any query parameter, and not matching a query parameter…