Skip to content
Browse files

it looks like chronic is only used for development/testing, so remove…

… gemspec dependency so it doesn't mess with downstream apps

Signed-off-by: Joel Nimety <jnimety@continuity.net>
  • Loading branch information...
1 parent 4c12cfa commit 60507b525d86658b96be7319f9e455376f1350c4 @jnimety committed Aug 22, 2011
Showing with 1 addition and 1 deletion.
  1. +1 −0 Gemfile
  2. +0 −1 metric_fu.gemspec
View
1 Gemfile
@@ -1,3 +1,4 @@
source "http://rubygems.org"
gem 'rake'
+gem 'chronic', "~> 0.3.0"
@crawlik
crawlik added a note Aug 22, 2011

No need to add gem 'chronic' and 'rake' in Gemfile according http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
gemspec
View
1 metric_fu.gemspec
@@ -20,7 +20,6 @@ Gem::Specification.new do |s|
s.add_dependency("reek", [">=1.2.6"])
s.add_dependency("roodi", [">=2.1.0"])
s.add_dependency("rails_best_practices", [">=0.6.4"])
- s.add_dependency("chronic", ["~> 0.3.0"])
@crawlik
crawlik added a note Aug 22, 2011

How about using s.add_development_dependency("chronic", ["~> 0.3.0"]) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
s.add_dependency("churn", [">= 0.0.7"])
s.add_dependency("Saikuro", [">= 1.1.0"])
s.add_dependency("activesupport", [">= 2.0.0"])

0 comments on commit 60507b5

Please sign in to comment.
Something went wrong with that request. Please try again.