Skip to content

Commit

Permalink
it looks like chronic is only used for development/testing, so remove…
Browse files Browse the repository at this point in the history
… gemspec dependency so it doesn't mess with downstream apps

Signed-off-by: Joel Nimety <jnimety@continuity.net>
  • Loading branch information
Joel Nimety committed Aug 22, 2011
1 parent 4c12cfa commit 60507b5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions Gemfile
@@ -1,3 +1,4 @@
source "http://rubygems.org"
gem 'rake'
gem 'chronic', "~> 0.3.0"

This comment has been minimized.

Copy link
@crawlik

crawlik Aug 22, 2011

No need to add gem 'chronic' and 'rake' in Gemfile according http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

gemspec
1 change: 0 additions & 1 deletion metric_fu.gemspec
Expand Up @@ -20,7 +20,6 @@ Gem::Specification.new do |s|
s.add_dependency("reek", [">=1.2.6"])
s.add_dependency("roodi", [">=2.1.0"])
s.add_dependency("rails_best_practices", [">=0.6.4"])
s.add_dependency("chronic", ["~> 0.3.0"])

This comment has been minimized.

Copy link
@crawlik

crawlik Aug 22, 2011

How about using s.add_development_dependency("chronic", ["~> 0.3.0"]) ?

s.add_dependency("churn", [">= 0.0.7"])
s.add_dependency("Saikuro", [">= 1.1.0"])
s.add_dependency("activesupport", [">= 2.0.0"])
Expand Down

0 comments on commit 60507b5

Please sign in to comment.