stat.mode was wrong because I inverted logic on the readonly check

jnr · Nov 12, 2015 · 865df23 · 865df23
1 parent 7b3acd2
commit 865df23
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/main/java/jnr/posix/windows/CommonFileInformation.java b/src/main/java/jnr/posix/windows/CommonFileInformation.java
@@ -49,7 +49,10 @@ public int getMode(java.lang.String path) {
         int attr = getFileAttributes();
         int mode = S_IRUSR;
 
-        if ((attr & FILE_ATTRIBUTE_READONLY) != 0) mode |= S_IWUSR;
+        if ((attr & FILE_ATTRIBUTE_READONLY) == 0) {
+            mode |= S_IWUSR;
+
+        }
         mode |= (attr & FILE_ATTRIBUTE_DIRECTORY) != 0 ? (S_IFDIR | S_IXUSR) : S_IFREG;
 
         path = path.toLowerCase();

diff --git a/src/test/java/jnr/posix/windows/WindowsFileTest.java b/src/test/java/jnr/posix/windows/WindowsFileTest.java
@@ -3,6 +3,7 @@
 import java.io.File;;
 import java.io.IOException;
 import java.io.RandomAccessFile;
+import java.text.NumberFormat;
 import jnr.posix.DummyPOSIXHandler;
 import jnr.posix.FileStat;
 import jnr.posix.POSIX;
@@ -91,6 +92,7 @@ public void testExecutableSuffixesAreExecutable() throws Throwable {
 
         try {
             FileStat st = posix.stat(f.getAbsolutePath());
+            assertEquals("100755", Integer.toOctalString(st.mode()));
             assertTrue(st.isExecutable());
         } finally {
             f.delete();
@@ -100,6 +102,7 @@ public void testExecutableSuffixesAreExecutable() throws Throwable {
 
         try {
             FileStat st = posix.stat(f.getAbsolutePath());
+            assertEquals("100755", Integer.toOctalString(st.mode()));
             assertTrue(st.isExecutable());
         } finally {
             f.delete();