Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed the bug of ignoring shell.replace return value. #22

Merged
merged 1 commit into from Mar 8, 2016

Conversation

Projects
None yet
3 participants
Contributor

ratnikov commented Nov 6, 2013

Got tripped up on this by error-prone (https://code.google.com/p/error-prone/wiki/ReturnValueIgnored)

Owner

headius commented Mar 8, 2016

Oops. Thank you.

headius added a commit that referenced this pull request Mar 8, 2016

Merge pull request #22 from ratnikov/master
Fixed the bug of ignoring shell.replace return value.

@headius headius merged commit 29e1db1 into jnr:master Mar 8, 2016

1 check passed

default The Travis CI build passed
Details

@headius headius added this to the 3.0.28 milestone Mar 8, 2016

Owner

enebo commented Mar 8, 2016

Hmmm it looks like a valid thing to do but I wonder if it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment