This repository was archived by the owner on Mar 1, 2018. It is now read-only.
Fix macupdate parse#181
Merged
Merged
Conversation
Contributor
|
Thanks, |
Contributor
Author
|
So, you see no problems with merging this? I didn't test by doing on a working machine, just through our rspec tests. I'll merge if you're happy with the changes. |
Contributor
|
It fixes the things that I found were broken and I can't think of anything that it could break (other than what was broken by Ginja's patch). So yes, please do go ahead and merge it. |
rickychilcott
pushed a commit
that referenced
this pull request
May 31, 2013
Fix macupdate parse. Thanks @mkuron for the vote of confidence!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now escaping URIs for MacUpdate so that we can parse spaces.
Also, trying to get all tests to pass. 2 are still failing, but I'm not sure what's causing them. I plan to get Jenkins configured so that we can force ourselves to flesh out our test suite.
Relates to #179 and should fix some of the problems @mkuron is reporting