Skip to content

Exception from the special treatment of XML tags with type == file #40

Merged
merged 1 commit into from Jun 5, 2013

2 participants

@admgre
admgre commented Oct 22, 2012

I was parsing an XML document (in this case, the XML configuration of a kvm domain) with Crack::XML.parse and it was throwing an exception.

After digging around this was because in the case where the tag has a type attribute set to file the children nodes are assumed to be strings. In this case the children are another XML tag and not a string causing an exception.

I also added a test as requested covering this bug.

@jnunemaker jnunemaker merged commit b176993 into jnunemaker:master Jun 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.