Percentage of actors with non sequential ids #12

Merged
merged 2 commits into from Nov 14, 2012

Conversation

Projects
None yet
2 participants
Contributor

eric commented Nov 12, 2012

This now uses crc32 to hash the IDs before calculating a percentage.

See #5 for more details.

eric added some commits Nov 12, 2012

@eric eric Hash identifier with crc32 for percentage gate
Allow for the identifier to not be a sequentially incrementing integer by
using a crc32 hash of the identifier.
670975b
@eric eric Add tests for new way percentages work b1ca5fe

@jnunemaker jnunemaker commented on the diff Nov 14, 2012

spec/integration_spec.rb
@@ -355,16 +353,6 @@ def enable_percentage_of_random(percentage)
end
end
- context "for actor in percentage of actors enabled" do
@jnunemaker

jnunemaker Nov 14, 2012

Owner

If we remove this, we should probably remove the context below it as well.

https://github.com/eric/flipper/blob/b1ca5fe128becf9e3f1f315bc011d9342b509df2/spec/integration_spec.rb#L356

I can do it post-merge though.

@jnunemaker jnunemaker added a commit that referenced this pull request Nov 14, 2012

@jnunemaker jnunemaker Merge pull request #12 from eric/percentage-of-actors-with-non-sequen…
…tial-ids

Percentage of actors with non sequential ids
3b84219

@jnunemaker jnunemaker merged commit 3b84219 into jnunemaker:master Nov 14, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment