Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd redis cache adapter #211
Conversation
camallen
added some commits
Dec 20, 2016
spec/helper.rb
Outdated
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| require 'rubygems' | |||
| require 'bundler' | |||
| require 'pry' | |||
This comment has been minimized.
This comment has been minimized.
camallen
added some commits
Jan 6, 2017
jnunemaker
merged commit 2100398
into
jnunemaker:master
Jan 7, 2017
1 check was pending
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
camallen
deleted the
camallen:redis_cache_adapter
branch
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
camallen commentedJan 6, 2017
closes #142 - first attempt at adding a redis cache adapter. I've added some testing setup that was broken and documented running them via docker-compose.
I mimicked the dalli cache adapter almost entirely, i think the only choices i had to make were is this included in the flipper-redis gem and how to use the setex cmd (ttl) with redis. I chose yes and to marshal objects when storing / retrieving, limited testing on this show the features serializing in and out of redis ok. Happy to change the implementation if you want.
Side note: when testing in the pry debugger, the inspect method on a feature would call the
adapter.gethere and warm the cache which took me a while to figure out. Maybe i should just make a note of this in the readme / wiki...?