New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename shadowing variable #248

Merged
merged 1 commit into from Mar 25, 2017

Conversation

Projects
None yet
2 participants
@nilbus
Contributor

nilbus commented Mar 25, 2017

Percentage#open? has 2 things named key, a method and a local variable that shadows it. This works fine but is confusing to read.

This patch renames the local variable, since #key is part of the Gate interface.

Rename shadowing variable
Percentage#open? has 2 things named key, a method and a local variable
that shadows it. This works fine but is confusing to read.

This patch renames the local variable, since #key is part of the Gate
interface.
@jnunemaker

This comment has been minimized.

Show comment
Hide comment
@jnunemaker

jnunemaker Mar 25, 2017

Owner

Ah nice. Thanks!

Owner

jnunemaker commented Mar 25, 2017

Ah nice. Thanks!

@jnunemaker jnunemaker merged commit 6f434b3 into jnunemaker:master Mar 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment